Skip to content

Move TestAccumuloClient initialization out of constructor #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Jun 22, 2022
Merged

Move TestAccumuloClient initialization out of constructor #12933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions plugin/trino-accumulo/src/test/java/io/trino/plugin/accumulo/TestAccumuloClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import io.trino.spi.connector.ConnectorTableMetadata;
import io.trino.spi.connector.SchemaTableName;
import org.apache.accumulo.core.client.Connector;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import java.util.HashMap;
Expand All @@ -36,10 +38,11 @@

public class TestAccumuloClient
{
private final AccumuloClient client;
private final ZooKeeperMetadataManager zooKeeperMetadataManager;
private AccumuloClient client;
private ZooKeeperMetadataManager zooKeeperMetadataManager;

public TestAccumuloClient()
@BeforeClass
public void setUp()
throws Exception
{
AccumuloConfig config = new AccumuloConfig()
Expand All @@ -52,6 +55,13 @@ public TestAccumuloClient()
client = new AccumuloClient(connector, config, zooKeeperMetadataManager, new AccumuloTableManager(connector), new IndexLookup(connector, new ColumnCardinalityCache(connector, config)));
}

@AfterClass(alwaysRun = true)
public void tearDown()
{
zooKeeperMetadataManager = null;
client = null;
}

@Test
public void testCreateTableEmptyAccumuloColumn()
{
Expand Down