Skip to content

Make AbstractRowBlock#copyPositions branchless #12926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 2 commits into from
Jun 23, 2022
Merged

Make AbstractRowBlock#copyPositions branchless #12926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb259a
Add RowBlock.copyPositions benchmark
lukasz-stec Jun 23, 2022
dfa8df4
Make AbstractRowBlock#copyPositions branchless
lukasz-stec Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions core/trino-spi/src/main/java/io/trino/spi/block/AbstractRowBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,10 @@ public Block copyPositions(int[] positions, int offset, int length)
for (int i = 0; i < length; i++) {
newOffsets[i] = fieldBlockPositionCount;
int position = positions[offset + i];
if (isNull(position)) {
newRowIsNull[i] = true;
}
else {
fieldBlockPositions[fieldBlockPositionCount++] = getFieldBlockOffset(position);
}
boolean positionIsNull = isNull(position);
newRowIsNull[i] = positionIsNull;
fieldBlockPositions[fieldBlockPositionCount] = getFieldBlockOffset(position);
fieldBlockPositionCount += positionIsNull ? 0 : 1;
}
// Record last offset position
newOffsets[length] = fieldBlockPositionCount;
Expand Down
69 changes: 55 additions & 14 deletions ...pi/block/BenchmarkVariableWidthBlock.java → ...ino/spi/block/BenchmarkCopyPositions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,14 @@
import org.openjdk.jmh.annotations.Warmup;
import org.testng.annotations.Test;

import java.util.Optional;
import java.util.Random;
import java.util.stream.IntStream;
import java.util.stream.LongStream;

import static com.google.common.base.Preconditions.checkState;
import static io.trino.jmh.Benchmarks.benchmark;
import static java.util.Objects.requireNonNull;
import static java.util.concurrent.TimeUnit.MICROSECONDS;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
import static org.openjdk.jmh.annotations.Mode.AverageTime;
Expand All @@ -41,7 +44,7 @@
@Warmup(iterations = 5, time = 1000, timeUnit = MILLISECONDS)
@Measurement(iterations = 10, time = 1000, timeUnit = MILLISECONDS)
@BenchmarkMode(AverageTime)
public class BenchmarkVariableWidthBlock
public class BenchmarkCopyPositions
{
private static final int SEED = 831;
private static final int POSITIONS = 8096;
Expand All @@ -51,7 +54,7 @@ public class BenchmarkVariableWidthBlock
public Block copyPositions(BenchmarkData data)
{
int[] positionIds = data.getPositionsIds();
return data.getVariableWidthBlock().copyPositions(positionIds, 0, positionIds.length);
return data.getBlock().copyPositions(positionIds, 0, positionIds.length);
}

@State(Thread)
Expand All @@ -70,27 +73,36 @@ public static class BenchmarkData
})
private SelectedPositions selectedPositions;

@Param({"VARCHAR", "ROW(BIGINT)"})
private String type;

private int[] positionsIds;
private Block variableWidthBlock;
private Block block;

public BenchmarkData(int selectedPositionsCount, boolean nullsAllowed, SelectedPositions selectedPositions)
public BenchmarkData(int selectedPositionsCount, boolean nullsAllowed, SelectedPositions selectedPositions, String type)
{
this.selectedPositionsCount = selectedPositionsCount;
this.nullsAllowed = nullsAllowed;
this.selectedPositions = selectedPositions;
this.selectedPositions = requireNonNull(selectedPositions, "selectedPositions is null");
this.type = requireNonNull(type, "type is null");
}

public BenchmarkData()
{
this(1000, false, SelectedPositions.SEQUENCE);
this(1000, false, SelectedPositions.SEQUENCE, "VARCHAR");
}

@Setup
public void setup()
{
positionsIds = selectedPositions.generateIds(selectedPositionsCount);
Slice[] slices = generateValues();
variableWidthBlock = createBlockBuilderWithValues(slices).build();
if (type.equals("VARCHAR")) {
Slice[] slices = generateValues();
block = createBlockBuilderWithValues(slices).build();
}
else if (type.equals("ROW(BIGINT)")) {
block = createRowBlock(POSITIONS, createRandomLongArrayBlock());
}
}

private Slice[] generateValues()
Expand Down Expand Up @@ -135,14 +147,36 @@ private static BlockBuilder createBlockBuilderWithValues(Slice[] generatedValues
return blockBuilder;
}

private static LongArrayBlock createRandomLongArrayBlock()
{
Random random = new Random(SEED);
return new LongArrayBlock(POSITIONS, Optional.empty(), LongStream.range(0, POSITIONS).map(i -> random.nextLong()).toArray());
}

private Block createRowBlock(int positionCount, Block... field)
{
Optional<boolean[]> rowIsNull = nullsAllowed ? Optional.of(generateIsNull(positionCount)) : Optional.empty();
return RowBlock.fromFieldBlocks(positionCount, rowIsNull, field);
}

private boolean[] generateIsNull(int positionCount)
{
Random random = new Random(SEED);
boolean[] result = new boolean[positionCount];
for (int i = 0; i < positionCount; i++) {
result[i] = randomNullChance(random);
}
return result;
}

public int[] getPositionsIds()
{
return positionsIds;
}

public Block getVariableWidthBlock()
public Block getBlock()
{
return variableWidthBlock;
return block;
}
}

Expand Down Expand Up @@ -197,17 +231,24 @@ public void testCopyPositions()
{
for (SelectedPositions selectedPositions : SelectedPositions.values()) {
for (boolean nullsAllowed : new boolean[] {false, true}) {
BenchmarkData data = new BenchmarkData(1024, nullsAllowed, selectedPositions);
data.setup();
copyPositions(data);
for (String type : new String[] {"VARCHAR", "ROW(BIGINT)"}) {
BenchmarkData data = new BenchmarkData(1024, nullsAllowed, selectedPositions, type);
data.setup();
copyPositions(data);
}
}
}
}

static {
// pollute profile
new BenchmarkCopyPositions().testCopyPositions();
}

public static void main(String[] args)
throws Exception
{
benchmark(BenchmarkVariableWidthBlock.class)
benchmark(BenchmarkCopyPositions.class)
.withOptions(optionsBuilder -> optionsBuilder.jvmArgsAppend("-Xmx4g", "-Xms4g"))
.run();
}
Expand Down