Implement INSERT tests in Kudu connector test#12921
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jun 22, 2022
chen-ni:issue-11815-part-2
Merged
Implement INSERT tests in Kudu connector test#12921ebyhr merged 1 commit intotrinodb:masterfrom chen-ni:issue-11815-part-2
ebyhr merged 1 commit intotrinodb:masterfrom
chen-ni:issue-11815-part-2
Conversation
ebyhr
approved these changes
Jun 22, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
You could change the commit title as
Implement INSERT tests in Kudu connector test
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
added
test
no-release-notes
chen-ni
changed the title
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An improvement in testing.
Connector tests.
Improved some tests that shouldn't change any behavior.
Related issues, pull requests, and links
A series of PRs will be created to implement #11815. This is the second one.
There are 12 remaining tests to fix in total, this PR fixes the first 4.
Additional notes
testInsert()is removed because the overridden test is working now as Fix failure when inserting into Kudu table having row uuid column #12915 fixed the issue;DATEtype, soSUPPORTS_NEGATIVE_DATEis updated;Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.