Abstain from passing UUID predicates to Iceberg library#12911
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 21, 2022
Conversation
Member
Author
|
|
homar
approved these changes
Jun 20, 2022
Trino and Iceberg seem to order UUID values differently.
findepi
force-pushed
the
findepi/abstain-from-passing-uuid-predicates-to-iceberg-library-3debf8
branch
from
6df9503 to
1e730f8
Compare
homar
approved these changes
Jun 20, 2022
ebyhr
approved these changes
Jun 20, 2022
alexjo2144
reviewed
Jun 21, 2022
| if (isMetadataColumnId(columnHandle.getId()) || isStructuralType(columnHandle.getType())) { | ||
| if (isMetadataColumnId(columnHandle.getId()) || isStructuralType(columnHandle.getType()) || | ||
| // Iceberg orders UUID values differently than Trino (perhaps due to https://bugs.openjdk.org/browse/JDK-7025832), so allow only IS NULL / IS NOT NULL checks | ||
| (columnHandle.getType() == UUID && !(domain.isOnlyNull() || domain.getValues().isAll()))) { |
Member
There was a problem hiding this comment.
Does an equality predicate work? Feels like asking for a range of UUIDs would be unusual but asking for rows matching a specific UUID would be common
Member
Author
There was a problem hiding this comment.
Equality is consistent between Trino and Java's UUID, but even for equality predicate the ordering matters when you match the searched-for value with file min/max information.
findepi
deleted the
findepi/abstain-from-passing-uuid-predicates-to-iceberg-library-3debf8
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trino and Iceberg seem to order UUID values differently.
This is a stop-gap solution that fixes #12834.
We can revisit this later as needed.