Support parameters in table function arguments#12910
Merged
kasiafi merged 1 commit intotrinodb:masterfrom Jun 21, 2022
Merged
Conversation
88093f9 to
ed683fb
Compare
Contributor
|
Thanks @kasiafi for this fix. It will go a long way to make PTF query pushdown work for regular use cases. |
ed683fb to
f0508a7
Compare
Member
|
The second example is not something we should generally recommend. It’s a vector for potential sql injection. |
Member
Author
I don't think we're going to prevent such usage. Maybe we should add a warning in the docs? |
Member
|
No, we’re not, but we shouldn’t provide such an example in the docs |
martint
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement. It allows you to use parameters in table function scalar arguments:
Documentation
Existing documentation is updated in this PR. Some examples (like the above) should be added to the documentation of the query pass-through table functions #12725 cc @colebow @mosabua
edit: @colebow @mosabua, I removed the second example, which included
query => format('SELECT * FROM %s', ?). As @martint noticed (#12910 (comment)), it is the kind of usage we shouldn't recommend in the docs.Release notes