[WIP] Add ORC support for the Iceberg Connector#1290
Closed
lxynov wants to merge 4 commits intotrinodb:masterfrom
Closed
[WIP] Add ORC support for the Iceberg Connector#1290lxynov wants to merge 4 commits intotrinodb:masterfrom
lxynov wants to merge 4 commits intotrinodb:masterfrom
Conversation
ORC's type definition has been expanded to include a list of user-defined attributes (apache/orc#410).
Member
|
@lxynov I confirmed you sent new PR to support ORC on Iceberg. Can we close this PR? |
Member
Author
|
@ebyhr Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the spec for ORC with Iceberg has not been finalized (https://iceberg.apache.org/spec/#orc is expected to change), the comments under apache/iceberg#227 show the direction. The problem to solve is that Iceberg tracks columns by IDs and ORC tracks them by names, which makes ORC not directly workable in Iceberg's semantics. According to the discussion in the Iceberg community, the current idea is to introduce user-defined type annotations to ORC (apache/orc#410), and use them to store Iceberg column IDs.
This WIP PR prototypes this idea in Presto.
Tests done:
TestIcebergSmokepasses with the ORC format.It shows
It shows
This is consistent with Iceberg's schema evolution semantics.
cc: @wagnermarkd @electrum