Skip to content

Implement testCreateTable and testDropTable in Kudu connector test #12899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jun 22, 2022
Merged

Implement testCreateTable and testDropTable in Kudu connector test #12899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 80 additions & 5 deletions plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import static java.util.Locale.ENGLISH;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNull;
import static org.testng.Assert.assertTrue;

public abstract class AbstractKuduConnectorTest
Expand Down Expand Up @@ -272,8 +274,73 @@ public void testExplainAnalyzeWithDeleteWithSubquery()
@Override
public void testCreateTable()
{
// TODO Support these test once kudu connector can create tables with default partitions
throw new SkipException("TODO");
// TODO Remove this overriding test once kudu connector can create tables with default partitions
String tableName = "test_create_" + randomTableSuffix();

assertUpdate("CREATE TABLE " + tableName + " (" +
"id INT WITH (primary_key=true)," +
"a bigint, b double, c varchar(50))" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));
assertTableColumnNames(tableName, "id", "a", "b", "c");
assertNull(getTableComment(getSession().getCatalog().orElseThrow(), getSession().getSchema().orElseThrow(), tableName));

assertUpdate("DROP TABLE " + tableName);
assertFalse(getQueryRunner().tableExists(getSession(), tableName));

assertQueryFails("CREATE TABLE " + tableName + " (" +
"id INT WITH (primary_key=true)," +
"a bad_type, b double, c varchar(50))" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)",
".* Unknown type 'bad_type' for column 'a'");
assertFalse(getQueryRunner().tableExists(getSession(), tableName));

tableName = "test_create_if_not_exists_" + randomTableSuffix();
assertUpdate("CREATE TABLE " + tableName + " (" +
"id INT WITH (primary_key=true)," +
"a bigint, b varchar(50), c double)" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));
assertTableColumnNames(tableName, "id", "a", "b", "c");

assertUpdate(
"CREATE TABLE IF NOT EXISTS " + tableName + " (" +
"id INT WITH (primary_key=true)," +
"d bigint, e varchar(50))" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));
assertTableColumnNames(tableName, "id", "a", "b", "c");
Comment thread
ebyhr marked this conversation as resolved.
Outdated

assertUpdate("DROP TABLE " + tableName);
assertFalse(getQueryRunner().tableExists(getSession(), tableName));

// Test CREATE TABLE LIKE
tableName = "test_create_origin_" + randomTableSuffix();
assertUpdate("CREATE TABLE " + tableName + " (" +
"id INT WITH (primary_key=true)," +
"a bigint, b double, c varchar(50))" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));
assertTableColumnNames(tableName, "id", "a", "b", "c");

// TODO: remove assertThatThrownBy and uncomment the commented lines
// and replace finalTableName with tableName
// after (https://github.com/trinodb/trino/issues/12469) is fixed
String tableNameLike = "test_create_like_" + randomTableSuffix();
final String finalTableName = tableName;
assertThatThrownBy(() -> assertUpdate(
"CREATE TABLE " + tableNameLike + " (LIKE " + finalTableName + ", " +
"d bigint, e varchar(50))" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)"))
.hasMessageContaining("This connector does not support creating tables with column comment");
//assertTrue(getQueryRunner().tableExists(getSession(), tableNameLike));
//assertTableColumnNames(tableNameLike, "a", "b", "c", "d", "e");

assertUpdate("DROP TABLE " + tableName);
assertFalse(getQueryRunner().tableExists(getSession(), tableName));

//assertUpdate("DROP TABLE " + tableNameLike);
//assertFalse(getQueryRunner().tableExists(getSession(), tableNameLike));
}

@Override
Expand All @@ -295,9 +362,17 @@ public void testCreateTableWithColumnComment()
@Override
public void testDropTable()
{
assertThatThrownBy(super::testDropTable)
.hasMessage("Table partitioning must be specified using setRangePartitionColumns or addHashPartitions");
throw new SkipException("TODO Enable the test once Kudu connector can create tables with default partitions");
// TODO Remove this overriding test once kudu connector can create tables with default partitions
String tableName = "test_drop_table_" + randomTableSuffix();
assertUpdate(
"CREATE TABLE " + tableName + "(" +
"id INT WITH (primary_key=true)," +
"col bigint)" +
"WITH (partition_by_hash_columns = ARRAY['id'], partition_by_hash_buckets = 2)");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));

assertUpdate("DROP TABLE " + tableName);
assertFalse(getQueryRunner().tableExists(getSession(), tableName));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,7 +2340,7 @@ public void testCommentTable()
}
}

private String getTableComment(String catalogName, String schemaName, String tableName)
protected String getTableComment(String catalogName, String schemaName, String tableName)
{
String sql = format("SELECT comment FROM system.metadata.table_comments WHERE catalog_name = '%s' AND schema_name = '%s' AND table_name = '%s'", catalogName, schemaName, tableName);
return (String) computeActual(sql).getOnlyValue();
Expand Down