Skip to content

Refining the Redis types in doc#12884

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
polaris6:add_redis_type_doc
Jun 17, 2022
Merged

Refining the Redis types in doc#12884
ebyhr merged 1 commit intotrinodb:masterfrom
polaris6:add_redis_type_doc

Conversation

@polaris6
Copy link
Copy Markdown
Member

@polaris6 polaris6 commented Jun 17, 2022

Description

Currently, the keyDataType can only be STRING and ZSET , the valueDataType can only be STRING and HASH .

Documentation

(✓) Sufficient documentation is included in this PR.

Release notes

(✓) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2022
@github-actions github-actions bot added the docs label Jun 17, 2022
@polaris6 polaris6 requested a review from ebyhr June 17, 2022 03:11
@polaris6
Copy link
Copy Markdown
Member Author

Hi @ebyhr, I think it might be more appropriate to call string column type here. I think there is no table type, the key and value have their own type.
#12881 (comment)

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 17, 2022

"string column type" is misleading. Most people will think about varchar or char types from the keyword. I will suggest a new entry later.

@polaris6
Copy link
Copy Markdown
Member Author

Yes I agree with you.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Jun 17, 2022
@ebyhr ebyhr merged commit a9cddc5 into trinodb:master Jun 17, 2022
@github-actions github-actions bot added this to the 387 milestone Jun 17, 2022
@polaris6 polaris6 deleted the add_redis_type_doc branch June 17, 2022 03:53
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 17, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed docs no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants