Skip to content

Smoke test timestamp values before epoch#12864

Merged
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/before-epoch-smoke-test
Jun 20, 2022
Merged

Smoke test timestamp values before epoch#12864
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/before-epoch-smoke-test

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 15, 2022

They often cause problems, especially when value isn't round number of
seconds or millis.

Additional test coverage for #12852

They often cause problems, especially when value isn't round number of
seconds or millis.
@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Jun 15, 2022
@cla-bot cla-bot bot added the cla-signed label Jun 15, 2022
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 20, 2022

Error:  io.trino.plugin.iceberg.TestIcebergParquetConnectorTest.testSplitPruningFromDataFileStatistics[timestamp(6) with time zone](21)  Time elapsed: 0.169 s  <<< FAILURE!
java.lang.RuntimeException: picosOfMilli must be >= 0
	at io.trino.testing.AbstractTestingTrinoClient.execute(AbstractTestingTrinoClient.java:122)
	at io.trino.testing.DistributedQueryRunner.executeWithQueryId(DistributedQueryRunner.java:541)
	at io.trino.plugin.iceberg.BaseIcebergConnectorTest.verifyPredicatePushdownDataRead(BaseIcebergConnectorTest.java:2846)
	at io.trino.plugin.iceberg.BaseIcebergConnectorTest.testSplitPruningFromDataFileStatistics(BaseIcebergConnectorTest.java:2829)
	at jdk.internal.reflect.GeneratedMethodAccessor1918.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.IllegalArgumentException: picosOfMilli must be >= 0

-- so indeed this would catch #12852

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 20, 2022

CI #12908

@findepi findepi merged commit 2f15006 into trinodb:master Jun 20, 2022
@findepi findepi deleted the findepi/before-epoch-smoke-test branch June 20, 2022 11:54
@github-actions github-actions bot added this to the 387 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry test

Development

Successfully merging this pull request may close these issues.

2 participants