Skip to content

Remove unused list prefix method from TrinoS3FileSystem#12845

Merged
electrum merged 1 commit intotrinodb:masterfrom
electrum:s3-listprefix
Jun 15, 2022
Merged

Remove unused list prefix method from TrinoS3FileSystem#12845
electrum merged 1 commit intotrinodb:masterfrom
electrum:s3-listprefix

Conversation

@electrum
Copy link
Copy Markdown
Member

Is this change a fix, improvement, new feature, refactoring, or other?

refactoring

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jun 14, 2022
@electrum electrum requested a review from hashhar June 14, 2022 21:41
@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 15, 2022

i guess it's not going to become used in @pettyjamesm 's #12443?

@electrum
Copy link
Copy Markdown
Member Author

@findepi That PR uses the standard Hadoop FileSystem.listFiles() method. The one removed here is a custom listFilesByPrefix() method.

@electrum electrum merged commit 9945d7e into trinodb:master Jun 15, 2022
@electrum electrum deleted the s3-listprefix branch June 15, 2022 16:50
@github-actions github-actions bot added this to the 386 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants