Skip to content

Require Java 11.0.15+#12841

Merged
martint merged 1 commit intotrinodb:masterfrom
martint:jdk11.0.15
Jun 16, 2022
Merged

Require Java 11.0.15+#12841
martint merged 1 commit intotrinodb:masterfrom
martint:jdk11.0.15

Conversation

@martint
Copy link
Copy Markdown
Member

@martint martint commented Jun 14, 2022

Description

There's a bug in earlier versions that causes a segfault: #12821

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

# General
* Update minimum required Java version to 11.0.15. ({issue}`12841`)

@cla-bot cla-bot bot added the cla-signed label Jun 14, 2022
@github-actions github-actions bot added the docs label Jun 14, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product tests fail with:

ERROR: Trino requires Java 11.0.15 at minimum (found 11.0.11+9-LTS)

Looks like test images also need a newer Java first: https://github.com/trinodb/docker-images/blob/master/testing/centos7-oj11/Dockerfile#L26

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 14, 2022

cc @trinodb/maintainers

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 15, 2022

Rationale for this PR: #12821 (comment)

It's probably due to https://bugs.openjdk.org/browse/JDK-8275610

@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Jun 16, 2022

This probably requires #12859 first

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 16, 2022

#12859 doesn't contain JDK change. We need to release new version again.

@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Jun 16, 2022

Scratch that. New release is necessary :)

I could add a logic to our docker images builds to use latest Azul JDK for a given major. Is this sth that we would like to have? @ebyhr @findepi @martint

There's a bug in earlier versions that causes a segfault: trinodb#12821
@martint
Copy link
Copy Markdown
Member Author

martint commented Jun 16, 2022

I could add a logic to our docker images builds to use latest Azul JDK for a given major. Is this sth that we would like to have?

I think we want to have explicit control over what version is being used. Otherwise, it makes builds less predictable, e.g., if there's a bug introduced in a newer version.

@martint martint merged commit 7823e01 into trinodb:master Jun 16, 2022
@github-actions github-actions bot added this to the 387 milestone Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants