Clarify limited write access in BigQuery docs#12840
Merged
martint merged 1 commit intotrinodb:masterfrom Jun 22, 2022
Merged
Conversation
martint
reviewed
Jun 14, 2022
hashhar
reviewed
Jun 15, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
We should be consistent and do what we have done in other connectors. i.e. mention both read and write in the paragraph and enumerate the specific ones that are supported in the bullet list.
mosabua
reviewed
Jun 15, 2022
Member
Author
|
Would it reasonable to include a "but write access is limited" or something like that to emphasize that you're only able to create tables/schemas? |
colebow
force-pushed
the
colebow/bigquery-docs
branch
from
39a0e79 to
e8942fd
Compare
mosabua
approved these changes
Jun 17, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
I am okay with this change for now. What we really should do is expand the write support and then get rid of this hedging that its limited again.
ebyhr
approved these changes
Jun 17, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please fix commit message. The latest change is not "Remove inaccurate mention of write access"
colebow
force-pushed
the
colebow/bigquery-docs
branch
from
e8942fd to
8579cbd
Compare
colebow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating docs to remove inaccurate info
Improvement
Docs only
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: