Verify accuracy of doing a CTAS statement from a versioned table#12839
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jun 22, 2022
Merged
Verify accuracy of doing a CTAS statement from a versioned table#12839ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
2 times, most recently
from
e543415 to
23b23e3
Compare
findinpath
commented
Jun 14, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
reviewed
Jun 14, 2022
Member
There was a problem hiding this comment.
Same comment elsewhere
Suggested change
| assertUpdate("INSERT INTO " + sourceTableName + " VALUES (1), (2), (3)", 3); | |
| assertUpdate("INSERT INTO " + sourceTableName + " VALUES 1, 2, 3", 3); |
Member
There was a problem hiding this comment.
Capitalization nit
Suggested change
| private long getCommittedAtInEpochMilliSeconds(String tableName, long snapshotId) | |
| private long getCommittedAtInEpochMilliseconds(String tableName, long snapshotId) |
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
from
23b23e3 to
09e514a
Compare
alexjo2144
reviewed
Jun 16, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Suggested change
| assertUpdate("CREATE TABLE " + sourceTableName + "(an_integer integer)"); | |
| assertUpdate("CREATE TABLE " + sourceTableName + "(an_integer INTEGER)"); |
Contributor
Author
There was a problem hiding this comment.
an_integer integer matches the convention in place used for the other tests.
Why do you suggest uppercasing the column type ?
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
2 times, most recently
from
bee1fca to
4814b5f
Compare
homar
reviewed
Jun 17, 2022
Member
There was a problem hiding this comment.
What is the point of this Thread.sleep? Next one makes sense but this one I don't understand.
Contributor
Author
There was a problem hiding this comment.
The reasoning behind this Thread.sleep(1) is to avoid having two snapshots at the timestamp afterInsert123EpochMillis
homar
reviewed
Jun 17, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
from
4814b5f to
6234469
Compare
homar
approved these changes
Jun 17, 2022
Member
|
LGTM % maven checks |
ebyhr
approved these changes
Jun 19, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
from
6234469 to
1caecf5
Compare
alexjo2144
approved these changes
Jun 21, 2022
findinpath
force-pushed
the
iceberg_ctas_versioned_table
branch
from
1caecf5 to
c524619
Compare
Member
|
Merged, thanks! |
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide how-to test on performing cloning of a table at specific point in the past.
Test
Iceberg connector
Provide how-to test on performing cloning of a table at specific point in the past.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: