Add tests for AS OF syntax for tables with redirects

[homar]

Description

Fixes: #12634

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(X) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[findinpath]

AsOfVersion is a bit misleading because the test verifies also the functionality of FOR TIMESTAMP ... syntax.

[homar]

right initially I wanted to have 2 different tests then I changed my mind

[findinpath]

You may want to add Thread.sleep(1) (same as in

trino/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergReadVersionedTable.java

Lines 46 to 54 in 4a0f84f

	public void setUp()
	throws InterruptedException
	{
	assertQuerySucceeds("CREATE TABLE test_iceberg_read_versioned_table(a_string varchar, an_integer integer)");
	assertQuerySucceeds("INSERT INTO test_iceberg_read_versioned_table VALUES ('a', 1)");
	v1SnapshotId = getLatestSnapshotId("test_iceberg_read_versioned_table");
	v1EpochMillis = getCommittedAtInEpochMilliSeconds("test_iceberg_read_versioned_table", v1SnapshotId);
	Thread.sleep(1);
	assertQuerySucceeds("INSERT INTO test_iceberg_read_versioned_table VALUES ('b', 2)");

) in order to avoid version collisions based on the same timestamp.

[homar]

I saw that but I thought this is unnecessary. I will add it if you think it makes sense

[findinpath]

It may very well happen that in the same millisecond there are two snapshots created and we can't distinguish then with the syntax FOR TIMESTAMP AS OF ... which snapshot we want to retrieve.

[homar]

I understand the problem I just doubt they will happen in the same milisecond.

[findinpath]

What is the added value of the queries having WHERE clauses in this context?
We're checking the table redirection functionality and not the table filter functionality here.

[homar]

I just wanted to make sure that the row I inserted is there. But you are right that doesn't bring much value

[findinpath]

Can we extract these methods to a utility class?
I think they are already multiple times duplicated.

[homar]

I will do that as a separate pr

[alexjo2144]

Let's not modify the nation table directly, make a copy first

[alexjo2144]

I should have been clearer in the issue, but I think the more interesting thing to test here is that queries on iceberg tables going through hive_with_redirections work.

Also that versioned queries on hive tables going through the iceberg_with_redirections catalog should not work. Something like select * from iceberg_with_redirection.schema.a_hive_tabl for timestamp as of ... should fail

[ebyhr]

I think this table affects other tests using information_schema. testReadInformationSchema & testShowTables will fail if they are executed at the same time.

[ebyhr]

Merged, thanks!