Skip to content

Describe per-connector support for fault-tolerant execution#12830

Merged
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/fte-connector-support
Jun 15, 2022
Merged

Describe per-connector support for fault-tolerant execution#12830
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/fte-connector-support

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Jun 13, 2022

Description

Add newly-uncovered information about per-connector support for fault-tolerant execution.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Adds information necessary to understand how fault-tolerant execution behaves with different connectors

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2022
@jhlodin jhlodin requested review from colebow and mosabua June 13, 2022 22:16
@github-actions github-actions bot added the docs label Jun 13, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a warning imho and remove the "Note that" and maybe also do not quote the error message specifically

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to warning and reworded a bit to emphasize the "warning" part of this note.

I think the error message text is important to put here, because when troubleshooting people are going to search for that text. The text also does not mention fault-tolerant execution making it harder to trace the cause back here.

We'll just have to update the text when it changes, business as usual.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we need to figure out how document that these three connectors support FTE in the actual connector doc

Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using abbreviations in the PR title and commit messages - makes it harder to skim commits for people who don't know what they mean.

LGTM % Manfred's comments.

@jhlodin jhlodin force-pushed the jl/fte-connector-support branch from cad42e0 to 198254b Compare June 14, 2022 21:42
@jhlodin jhlodin force-pushed the jl/fte-connector-support branch from 198254b to 415dd15 Compare June 14, 2022 21:43
@jhlodin jhlodin changed the title Add note about per-connector support for FTE operations Describe per-connector support for fault-tolerant execution Jun 14, 2022
@martint martint merged commit 0c19f3e into trinodb:master Jun 15, 2022
@jhlodin jhlodin deleted the jl/fte-connector-support branch June 15, 2022 16:36
@github-actions github-actions bot added this to the 386 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants