Ensure Iceberg test waits for dynamic filtering#12829
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jun 17, 2022
Merged
Conversation
Member
Author
|
Testing with |
alexjo2144
force-pushed
the
iceberg/flaky-df-test
branch
from
1818a13 to
685eba5
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/flaky-df-test
branch
from
685eba5 to
72dac46
Compare
raunaqmorarka
approved these changes
Jun 14, 2022
Member
There was a problem hiding this comment.
nit : I would keep timeout something between 20-30 sec since CI workers are small nodes and we do encounter GC pauses
Member
Author
There was a problem hiding this comment.
Sure, bumped it to 25s
alexjo2144
force-pushed
the
iceberg/flaky-df-test
branch
from
72dac46 to
3b58a1b
Compare
Member
Author
|
Also fixed a small typo, |
hashhar
approved these changes
Jun 17, 2022
hashhar
added
test
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testLocalDynamicFilteringWithSelectiveBuildSizeJointests that a local Dynamic Filter is applied, so it should have a wait time set to ensure the filter is available.Test change only
Test change only
Test change only
Related issues, pull requests, and links
Fixes: #10932
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: