Skip to content

Remove unnecessary bind in ui module#12823

Closed
polaris6 wants to merge 1 commit intotrinodb:masterfrom
polaris6:remove-unnecessary-bind
Closed

Remove unnecessary bind in ui module#12823
polaris6 wants to merge 1 commit intotrinodb:masterfrom
polaris6:remove-unnecessary-bind

Conversation

@polaris6
Copy link
Copy Markdown
Member

Description

Binding is unnecessary, so I removed it.

Documentation

(✓) No documentation is needed.

Release notes

(✓) No release notes entries required.

@polaris6 polaris6 force-pushed the remove-unnecessary-bind branch from 5ea6ef8 to 0ea0e78 Compare June 14, 2022 01:58
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red.

@polaris6
Copy link
Copy Markdown
Member Author

@ebyhr Sorry, I misunderstood, I will close this PR.
Do you have time to help review this PR recently? This PR has been around for a long time, I really appreciate it!

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 14, 2022

@polaris6 I will review the PR when I have time. (maybe in this week)

@ebyhr ebyhr closed this Jun 14, 2022
@polaris6 polaris6 deleted the remove-unnecessary-bind branch June 14, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants