Skip to content

Conversation

@dain
Copy link
Member

@dain dain commented Jun 11, 2022

Description

This PR:

  • Adds TestingThriftHiveMetastoreBuilder to simplify tests
  • Encapsulates creation of Thrift metastore in ThriftMetastoreFactory
  • Moved identity from Thrift metastore methods to the constructor
  • Removes HiveIdentity

Documentation

(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(X) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jun 11, 2022
@dain dain requested a review from electrum June 11, 2022 22:22
@dain dain force-pushed the metastore-simplify-creation branch from 8cdadab to b202da2 Compare June 11, 2022 22:28
@hashhar hashhar requested review from ebyhr and findepi June 13, 2022 08:10
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix CI failures?

@dain dain force-pushed the metastore-simplify-creation branch 2 times, most recently from a297a53 to 69a4ef6 Compare June 25, 2022 18:57
@dain dain force-pushed the metastore-simplify-creation branch from 69a4ef6 to 4e24f76 Compare June 25, 2022 20:12
@dain dain merged commit c9f881f into trinodb:master Jun 25, 2022
@github-actions github-actions bot added this to the 388 milestone Jun 25, 2022
@dain dain deleted the metastore-simplify-creation branch June 26, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants