Avoid using futures to collect DFs on workers#12801
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Jun 16, 2022
Merged
Conversation
arhimondr
approved these changes
Jun 10, 2022
Member
|
Nit: the description wrapping seems quite narrow |
For collecting DFs for fault tolerant execution it is necessary to update the final version of dynamic filters in DynamicFiltersCollector before completion of the task. This ensures that the coordinator will be aware about the need to fetch dynamic filters from a worker even after the task has finished running.
raunaqmorarka
force-pushed
the
remove-future
branch
from
1a62faa to
2b3f3cc
Compare
Member
Author
|
I've run TPC benchmarks and verified that there's no significant changes in results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For collecting DFs for fault tolerant execution it is necessary
to update the final version of dynamic filters in DynamicFiltersCollector
before completion of the task. This ensures that the coordinator will be
aware about the need to fetch dynamic filters from a worker even after
the task has finished running.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: