Fix Iceberg ignoring filter on $path#12790
Merged
findepi merged 3 commits intotrinodb:masterfrom Jun 13, 2022
Merged
Conversation
findepi
changed the title
findepi
force-pushed
the
findepi/fix-iceberg-ignoring-filter-on-902029
branch
from
df322f4 to
b769e8a
Compare
findepi
force-pushed
the
findepi/fix-iceberg-ignoring-filter-on-902029
branch
from
b769e8a to
b195eb9
Compare
findepi
commented
Jun 10, 2022
| assertThat(query("SELECT userid FROM " + tableName + " WHERE \"$path\" = '" + somePath + "'")) | ||
| .matches("VALUES 2, 5"); | ||
| assertThat(query("SELECT userid FROM " + tableName + " WHERE \"$path\" = '" + somePath + "' AND userid > 0")) | ||
| .matches("VALUES 2, 5"); |
Member
Author
There was a problem hiding this comment.
The first one was passing, but this one was failing.
alexjo2144
approved these changes
Jun 10, 2022
Member
|
CI button looks green but jobs didn't actually run |
phd3
approved these changes
Jun 10, 2022
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
how about an commit message like
Fix filtering on $path column for iceberg queries
Member
Author
This could be understood as if now filtering happens within the connector. |
electrum
approved these changes
Jun 13, 2022
hashhar
approved these changes
Jun 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12789