Replace var usages with explciit type#12787
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 13, 2022
Merged
Conversation
Per development guidelines, `var` is discouraged.
findepi
added
maintenance
ebyhr
approved these changes
Jun 12, 2022
| { | ||
| var executionBinder = newMapBinder(binder, new TypeLiteral<Class<? extends Statement>>() {}, new TypeLiteral<QueryExecutionFactory<?>>() {}); | ||
| MapBinder<Class<? extends Statement>, QueryExecutionFactory<?>> executionBinder = | ||
| newMapBinder(binder, new TypeLiteral<Class<? extends Statement>>() {}, new TypeLiteral<QueryExecutionFactory<?>>() {}); |
Member
There was a problem hiding this comment.
nit: How about replacing types with <> here and L177?
newMapBinder(binder, new TypeLiteral<>() {}, new TypeLiteral<>() {});
Member
Author
There was a problem hiding this comment.
the idea of TypeLiteral<T>() {} is to capture the T (hence anonymous subclass). It should be explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per development guidelines,
varis discouraged.References