Skip to content

Fix decoding Float to REAL in Kafka Avro #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jun 10, 2022
Merged

Fix decoding Float to REAL in Kafka Avro #12784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/trino-record-decoder/src/main/java/io/trino/decoder/avro/AvroColumnDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ public long getLong()
if (value instanceof Long || value instanceof Integer) {
return ((Number) value).longValue();
}
if (value instanceof Float && columnType == RealType.REAL) {
return floatToIntBits((float) value);
}
throw new TrinoException(DECODER_CONVERSION_NOT_SUPPORTED, format("cannot decode object of '%s' as '%s' for column '%s'", value.getClass(), columnType, columnName));
}

Expand Down
6 changes: 3 additions & 3 deletions plugin/trino-kafka/src/test/java/io/trino/plugin/kafka/TestKafkaConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,10 +742,10 @@ private static List<RoundTripTestCase> roundTripAllFormatsData()
return ImmutableList.<RoundTripTestCase>builder()
.add(new RoundTripTestCase(
"all_datatypes_avro",
ImmutableList.of("f_bigint", "f_double", "f_boolean", "f_varchar"),
ImmutableList.of("f_bigint", "f_float", "f_double", "f_boolean", "f_varchar"),
ImmutableList.of(
ImmutableList.of(100000, 1000.001, true, "'test'"),
ImmutableList.of(123456, 1234.123, false, "'abcd'"))))
ImmutableList.of(100000, 999.999f, 1000.001, true, "'test'"),
ImmutableList.of(123456, -123.456f, 1234.123, false, "'abcd'"))))
.add(new RoundTripTestCase(
"all_datatypes_csv",
ImmutableList.of("f_bigint", "f_int", "f_smallint", "f_tinyint", "f_double", "f_boolean", "f_varchar"),
Expand Down
5 changes: 5 additions & 0 deletions plugin/trino-kafka/src/test/resources/write_test/all_datatypes_avro.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
"mapping": "f_bigint"
},
{
"name": "f_float",
"type": "REAL",
"mapping": "f_float"
},
{
"name": "f_double",
"type": "DOUBLE",
"mapping": "f_double"
Expand Down
5 changes: 5 additions & 0 deletions plugin/trino-kafka/src/test/resources/write_test/all_datatypes_avro_message_schema.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
"type":["null", "long"],
"default": null
},
{
"name": "f_float",
"type":["null", "float"],
"default": null
},
{
"name": "f_double",
"type":["null", "double"],
Expand Down