Merged
Conversation
losipiuk
approved these changes
Jun 9, 2022
Member
|
Please add release notes using PR message template |
Member
|
Are there some docs changes needed? |
Member
|
LGTM, but there are conflicts. |
electrum
approved these changes
Jun 9, 2022
wendigo
force-pushed
the
serafin/remove-phoenix4
branch
from
e34e5f1 to
c044036
Compare
Contributor
Author
|
@findepi rebased. Sorry for that (old master) |
wendigo
force-pushed
the
serafin/remove-phoenix4
branch
from
c044036 to
ffe2d21
Compare
Contributor
Author
|
And docs updated. |
wendigo
force-pushed
the
serafin/remove-phoenix4
branch
from
ffe2d21 to
fdee7cf
Compare
ebyhr
approved these changes
Jun 9, 2022
...cher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodePhoenix4.java
Outdated
Show resolved
Hide resolved
...ts-launcher/src/main/java/io/trino/tests/product/launcher/suite/suites/Suite6NonGeneric.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/remove-phoenix4
branch
from
fdee7cf to
b9afd5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed with https://github.com/orgs/trinodb/teams/maintainers over slack thread https://trinodb.slack.com/archives/CP1MUNEUX/p1654514925872899
Decline :)
Connector
Remove support for connecting to Phoenix 4 cluster
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: