Skip to content

Make IcebergTableHandle.enforcedPredicate coordinator-only#12766

Closed
findepi wants to merge 2 commits intotrinodb:masterfrom
findepi:findepi/make-icebergtablehandle-enforcedpredicate-coordinator-only-7f6153
Closed

Make IcebergTableHandle.enforcedPredicate coordinator-only#12766
findepi wants to merge 2 commits intotrinodb:masterfrom
findepi:findepi/make-icebergtablehandle-enforcedpredicate-coordinator-only-7f6153

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 9, 2022

Some minor prep for #7905 (#12362)

findepi added 2 commits June 9, 2022 16:27
Don't invoke `IcebergTableHandle` constructor meant for deserialization
explicitly. This fixes potential information loss in
`IcebergMetadata.applyFilter` (it's believed it doesn't matter).

To prevent future mistakes, the deserialization constructor is changed
to a factory method.
The property is not used on workers (and shouldn't be, as it's the
enforced one). Don't send it there.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 9, 2022
@cla-bot cla-bot bot added the cla-signed label Jun 9, 2022
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 9, 2022

Seems like IcebergMetadata.finishUpdate is called on the coordinator, but still gets handle from serialized form.

@findepi findepi closed this Jun 9, 2022
@findepi findepi deleted the findepi/make-icebergtablehandle-enforcedpredicate-coordinator-only-7f6153 branch June 9, 2022 14:37
@findepi findepi mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

1 participant