Attach weights to DeltaLakeSplits#12755
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jun 14, 2022
Merged
Conversation
alexjo2144
suggested changes
Jun 9, 2022
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplit.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
The weight is equal to the split size divided by the target split size.
alexjo2144
approved these changes
Jun 10, 2022
findepi
approved these changes
Jun 14, 2022
| fileSize, | ||
| addFileEntry.getModificationTime(), | ||
| ImmutableList.of(), | ||
| SplitWeight.fromProportion(Math.min(Math.max((double) splitSize / maxSplitSize, minimumAssignedSplitWeight), 1.0)), |
Member
There was a problem hiding this comment.
Math.min( ..., 1) is redundant per my understanding.
nit: static import min & max
Member
There was a problem hiding this comment.
Math.min( ..., 1)is redundant per my understanding.
ie if we somehow end up creating an oversized split, it's fine to let the engine know about that.
Member
Member
Author
|
Let me merge this as-is. Thanks for your follow-up PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attach weights to DeltaLakeSplits.
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) Release notes entries required with the following suggested text: