Adjust trino-exchange-filesystem excludes#12742
Closed
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Closed
Adjust trino-exchange-filesystem excludes#12742losipiuk wants to merge 1 commit intotrinodb:masterfrom
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Conversation
This commit excludes GCS related dependecies of trino-exchange-filesystem used as test dependency more aggresively. Previously the transitive dependencies of trino-exchange-filesystem creeped into compile scope of modules which included it as test dependency (trino-hive, trino-iceberg, trino-delta). Some dependencies were rescoped from `compile` to `test` and as result queries were failing at runtime with NoClassDefFoundError. See trinodb#12674
arhimondr
approved these changes
Jun 8, 2022
Contributor
arhimondr
left a comment
arhimondr
left a comment
There was a problem hiding this comment.
Wow, i would have never though that test scope dependencies can impact compile scope dependencies in any way.
Member
Author
|
This approach does not work still :/ too aggressive - no classes are missing in tests :( |
Member
Author
|
Closed in favor of #12746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit excludes GCS related dependecies of
trino-exchange-filesystem used as test dependency more aggresively.
Previously the transitive dependencies of trino-exchange-filesystem
creeped into compile scope of modules which included it as test
dependency (trino-hive, trino-iceberg, trino-delta). Some dependencies
were rescoped from
compiletotestand as result queries werefailing at runtime with NoClassDefFoundError.
See #12674
Related issues, pull requests, and links
Bandaid fix for #12674.
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: