Skip to content

Return addresses in PhoenixSplit.getInfo()#12741

Merged
ebyhr merged 4 commits intotrinodb:masterfrom
rameshbabu-sfdc:master
Jun 9, 2022
Merged

Return addresses in PhoenixSplit.getInfo()#12741
ebyhr merged 4 commits intotrinodb:masterfrom
rameshbabu-sfdc:master

Conversation

@rameshbabu-sfdc
Copy link
Copy Markdown
Contributor

@rameshbabu-sfdc rameshbabu-sfdc commented Jun 8, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?
logging change
Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
connector
How would you describe this change to a non-technical end user or system administrator?
logging addresses for debug purpose

Related issues, pull requests, and links

Documentation

( x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 8, 2022
@ebyhr ebyhr changed the title https://github.com/trinodb/trino/issues/10757 Add more information about the split in PhoenixSplit getInfo() Jun 8, 2022
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix trino-phoenix5 module as well.

Also, please squash commits into one and fix the commit title (≠ PR title) as "Return addresses in PhoenixSplit.getInfo()".
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@rameshbabu-sfdc rameshbabu-sfdc changed the title Add more information about the split in PhoenixSplit getInfo() Return addresses in PhoenixSplit.getInfo() Jun 8, 2022
Copy link
Copy Markdown
Contributor Author

@rameshbabu-sfdc rameshbabu-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the required suggestions @ebyhr

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder

Also, please squash commits into one and fix the commit title (≠ PR title) as "Return addresses in PhoenixSplit.getInfo()".
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@rameshbabu-sfdc
Copy link
Copy Markdown
Contributor Author

@ebyhr docker tests failed with the below error. Any idea how to resolve this ?

Warning: rning] The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64) and no specific platform was requested

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Jun 9, 2022
@ebyhr ebyhr merged commit 36944a2 into trinodb:master Jun 9, 2022
@github-actions github-actions bot added this to the 386 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

Add more information about the split in PhoenixSplit getInfo()

2 participants