Return addresses in PhoenixSplit.getInfo()#12741
Conversation
ebyhr
left a comment
There was a problem hiding this comment.
Please fix trino-phoenix5 module as well.
Also, please squash commits into one and fix the commit title (≠ PR title) as "Return addresses in PhoenixSplit.getInfo()".
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixSplit.java
Outdated
Show resolved
Hide resolved
plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixSplit.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Implemented the required suggestions @ebyhr
ebyhr
left a comment
There was a problem hiding this comment.
Reminder
Also, please squash commits into one and fix the commit title (≠ PR title) as "Return addresses in PhoenixSplit.getInfo()".
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixSplit.java
Outdated
Show resolved
Hide resolved
|
@ebyhr docker tests failed with the below error. Any idea how to resolve this ? Warning: rning] The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64) and no specific platform was requested |
Description
Related issues, pull requests, and links
Documentation
( x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: