Reduce trino-tests' memory footprint#12735
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 8, 2022
Merged
Conversation
On CI it was observed to improve test times, preventing build timeouts.
This was referenced Jun 8, 2022
ebyhr
approved these changes
Jun 8, 2022
nineinchnick
approved these changes
Jun 8, 2022
kokosing
reviewed
Jun 9, 2022
| A potential downside can be long tail single-threaded execution of a single long test class. | ||
| TODO (https://github.com/trinodb/trino/issues/11294) remove when we upgrade to surefire with https://issues.apache.org/jira/browse/SUREFIRE-1967 | ||
| --> | ||
| <air.test.parallel>instances</air.test.parallel> |
Member
There was a problem hiding this comment.
I told you once that this sounds like much safer default. While we are using the more "speedy" one.
Member
Author
There was a problem hiding this comment.
yeah, and i didn't want to listen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CI it was observed to improve test times, preventing build timeouts.
Verified with #12727
Fixes #11634