Skip to content

Support comment when adding a new column (ALTER TABLE ADD COLUMN) in Delta Lake#12715

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr:ebi/delta-add-column-with-comment
Jun 8, 2022
Merged

Support comment when adding a new column (ALTER TABLE ADD COLUMN) in Delta Lake#12715
ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr:ebi/delta-add-column-with-comment

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jun 7, 2022

Description

Support comment when adding a new column in Delta Lake
Fixes #12424

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# Delta Lake
* Support comment when adding a new column. ({issue}`12715`)

@cla-bot cla-bot bot added the cla-signed label Jun 7, 2022
@ebyhr ebyhr changed the title Support comment when adding a new column in Delta Lake Support comment when adding a new column (ALTER TABLE ADD COLUMN) in Delta Lake Jun 7, 2022
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing/bin/ptl test run --environment 'EnvSinglenodeDeltaLakeOss' -- -t io.trino.tests.product.deltalake.TestDeltaLakeDatabricksAlterTableCompatibility

The test works also on Delta OSS . Please do add the group DELTA_LAKE_OSS to the test and rename the class to TestDeltaLakeAlterTableCompatibility

@ebyhr ebyhr force-pushed the ebi/delta-add-column-with-comment branch from e3b6e43 to 9f10cc0 Compare June 7, 2022 09:35
Copy link
Copy Markdown
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ebyhr ebyhr merged commit 08187fc into trinodb:master Jun 8, 2022
@ebyhr ebyhr deleted the ebi/delta-add-column-with-comment branch June 8, 2022 00:15
@ebyhr ebyhr mentioned this pull request Jun 8, 2022
@github-actions github-actions bot added this to the 385 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Support table and column comments in Delta Lake

4 participants