Conversation
core/trino-main/src/main/java/io/trino/connector/ConnectorManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
there is nothing (obvious) which would prevent finished flag from changing to true just after checkState and before we get the metadata. Is that a problem?
There was a problem hiding this comment.
This commit is just reorganizing the existing code in the transaction manager. In this case the transaction manager is enforcing a single threaded access to this object that ensures that ensures safe access to this object. Technically, I think we could synchronize abort and commit, but I'm not 100% sure of the impact. Regardless we would do that in a separate commit
There was a problem hiding this comment.
Ya, I'm sure there is a better name, but I don't think parent is the right term. These don't really from a hierarchy. These internal, synthetic, names are really just a hack to deal with the very strange system and information schema tables.
core/trino-main/src/main/java/io/trino/connector/ConnectorManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/CatalogMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/jdbc/ColumnJdbcTable.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/jdbc/SchemaJdbcTable.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/jdbc/TableJdbcTable.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/transaction/TransactionManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/transaction/InMemoryTransactionManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/MaterializedViewSystemTable.java
Show resolved
Hide resolved
3 participants
Description
Various cleanups from recent work.
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(X) No release notes entries required.
( ) Release notes entries required with the following suggested text: