Allow cancelling the query to cancel waiting for Hive lock#12705
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 8, 2022
Merged
Allow cancelling the query to cancel waiting for Hive lock#12705findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
findepi
approved these changes
Jun 6, 2022
Member
|
@homar please formulate RNs |
dain
reviewed
Jun 6, 2022
Member
There was a problem hiding this comment.
I have no comment on if this is the right solution, but if it is, I would move this synchronized block to a new synchronized method named getHiveTransaction
Member
There was a problem hiding this comment.
i liked the synchronized (this) version more because it clearly conveyed the intent that the subsequent call is outside of the synchronization.
Either restore, or add a code comment documenting the intent.
Member
Author
There was a problem hiding this comment.
I prefer code to tell the story instead of comments so I will restore.
homar
force-pushed
the
homar/clean_up_hive_locks_in_waiting_stage
branch
2 times, most recently
from
187503d to
fca09e5
Compare
homar
force-pushed
the
homar/clean_up_hive_locks_in_waiting_stage
branch
from
fca09e5 to
4e3e6f3
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11798
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: