Skip to content

Test: Enable Select pushdown on uncompressed files#12702

Closed
findepi wants to merge 2 commits intomasterfrom
findepi/test/12633/select-pushdown-uncompressed
Closed

Test: Enable Select pushdown on uncompressed files#12702
findepi wants to merge 2 commits intomasterfrom
findepi/test/12633/select-pushdown-uncompressed

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 6, 2022

test for #12633 with secrets

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 6, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@preethiratnam
Copy link
Copy Markdown
Contributor

Hi @ilfrin @nineinchnick there are some tests failing on the Iceberg plugin. I'm not sure if it was caused by my changes in the Hive plugin. Can you please help debug?

@nineinchnick
Copy link
Copy Markdown
Member

Hi @ilfrin @nineinchnick there are some tests failing on the Iceberg plugin. I'm not sure if it was caused by my changes in the Hive plugin. Can you please help debug?

I don't know anything about these, but looks like you should rebase over latest master to include #12707

@preethiratnam
Copy link
Copy Markdown
Contributor

preethiratnam commented Jun 7, 2022

I don't know anything about these, but looks like you should rebase over latest master to include #12707

Hi @nineinchnick I've now rebased to latest master on #12633. Can you please re-run the tests?

@nineinchnick
Copy link
Copy Markdown
Member

I'm not a maintainer and I don't have any permissions in this repository. @findepi can you do this? BTW I am currently working on streamlining this :-)

@findepi findepi force-pushed the findepi/test/12633/select-pushdown-uncompressed branch from 6739925 to de704fa Compare June 7, 2022 14:19
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 7, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 7, 2022

BTW I am currently working on streamlining this :-)

Thanks you @nineinchnick

Can you please re-run the tests?

done

@findepi findepi closed this Jul 19, 2022
@findepi findepi deleted the findepi/test/12633/select-pushdown-uncompressed branch July 19, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants