Refactor class loader safety in Iceberg and Delta split managers#12699
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 6, 2022
Conversation
findepi
force-pushed
the
findepi/fix-class-loader-safety-in-icebergsplitmanager-70849a
branch
from
c8e1ca3 to
ad47dfe
Compare
Instantiating `ClassLoaderSafeConnectorSplitSource` with TCCL was OK, because the split manager itself is wrapped in `ClassLoaderSafeConnectorSplitManager`, so the TCCL is the plugin class loader. However, the code could be more explicit.
findepi
force-pushed
the
findepi/fix-class-loader-safety-in-icebergsplitmanager-70849a
branch
from
ad47dfe to
d3c0474
Compare
findepi
changed the title
findepi
added
the
no-release-notes
losipiuk
approved these changes
Jun 6, 2022
findepi
deleted the
findepi/fix-class-loader-safety-in-icebergsplitmanager-70849a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instantiating
ClassLoaderSafeConnectorSplitSourcewith TCCL was OK,because the split manager itself is wrapped in
ClassLoaderSafeConnectorSplitManager, so the TCCL is the plugin classloader. However, the code could be more explicit.