Fix query table function tests in SingleStore#12696
Merged
Conversation
ebyhr
added
the
no-release-notes
kokosing
reviewed
Jun 6, 2022
| // to execute in SingleStore because the connector wraps it in additional syntax, which causes syntax error. | ||
| try (TestTable testTable = simpleTable()) { | ||
| assertThatThrownBy(() -> query(format("SELECT * FROM TABLE(system.query(query => 'INSERT INTO %s VALUES (3)'))", testTable.getName()))) | ||
| .hasMessageContaining("descriptor has no fields"); |
Member
There was a problem hiding this comment.
I am not sure if it is the way to go. It sounds like we should disable this feature (system.query table function) in single-store as this not working fully.
findepi
approved these changes
Jun 6, 2022
Member
|
Approved because per my understand this similar to what we do for MariaDB |
Member
|
Fixes master, so let me merge. |
Member
|
thank you @ebyhr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix query table function tests in SingleStore
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.