Document that most config properties are set on all nodes#12688
Merged
martint merged 1 commit intotrinodb:masterfrom Jun 22, 2022
Merged
Document that most config properties are set on all nodes#12688martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
Contributor
Author
|
There may be other places in the docs where this can be better clarified, but I think this is a simple addition. To do this in more depth would probably require an overhauling of Trino installation instructions. |
mosabua
requested changes
Jun 3, 2022
def5c37 to
db0b8f5
Compare
mosabua
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a recurring question in the Trino slack, of beginners wondering which nodes require what configuration properties. This PR helps set the expectation that, by default, admins should assume a property is set on all nodes (coordinator and workers) unless documented otherwise.
Improvement
Documentation
Improves the properties documentation to be more clear about how they should be configured.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: