Document JSON value constructors#12677
Merged
kasiafi merged 1 commit intotrinodb:masterfrom Jun 8, 2022
Merged
Conversation
mosabua
requested changes
Jun 3, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Great job. Just minor things.
One question I have .. you chose to not use sql for the code blocks but text instead .. and also did not rely on the the :: before the snippets. Is that on purpose because it does not work somehow for you? If not .. we might want to change them all
kasiafi
force-pushed
the
364DocumentJsonValueConstructors
branch
from
19cfd86 to
cfcb2b8
Compare
Member
Author
|
@mosabua I applied your comments. I changed the text blocks into SQL blocks using |
losipiuk
approved these changes
Jun 6, 2022
Closed
mosabua
approved these changes
Jun 7, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Awesome. Basically flawless now. Ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for #12049.