Fix PositionsAppender#build for null Block#12670
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Jun 3, 2022
Merged
Conversation
sopel39
approved these changes
Jun 2, 2022
core/trino-main/src/main/java/io/trino/operator/output/SlicePositionsAppender.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/output/TestPagePartitioner.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Jun 2, 2022
core/trino-main/src/test/java/io/trino/operator/output/TestPagePartitioner.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Jun 2, 2022
core/trino-main/src/test/java/io/trino/operator/output/TestPagePartitioner.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Jun 3, 2022
Member
There was a problem hiding this comment.
Think about other edge cases too:
- Empty block
- Rle followed by empty block
- Empty rle followed by null block
Can be separate PR too
Member
Author
There was a problem hiding this comment.
Since build must reset the appenders state I added these cases in one go in io.trino.operator.output.TestPositionsAppender#testConsecutiveBuilds
If the created block had only null positions the dedicated PositionAppender's were not correctly reset.
lukasz-stec
force-pushed
the
ls/019-poo-null-block-fix
branch
from
480f4d4 to
d7d2757
Compare
lukasz-stec
commented
Jun 3, 2022
Member
Author
lukasz-stec
left a comment
lukasz-stec
left a comment
There was a problem hiding this comment.
comments addressed
core/trino-main/src/test/java/io/trino/operator/output/TestPagePartitioner.java
Outdated
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
Since build must reset the appenders state I added these cases in one go in io.trino.operator.output.TestPositionsAppender#testConsecutiveBuilds
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the created block had only null positions
the dedicated PositionAppender's were
not correctly reset.
Fix
bug fix
Related issues, pull requests, and links
Fixes #12667
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: