Skip to content

Test with GCS#12663

Closed
findepi wants to merge 4 commits intomasterfrom
findepi/test-with-gcs
Closed

Test with GCS#12663
findepi wants to merge 4 commits intomasterfrom
findepi/test-with-gcs

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 2, 2022

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 2, 2022
@findinpath findinpath self-requested a review June 9, 2022 07:49
@findepi findepi force-pushed the findepi/test-with-gcs branch from a655816 to ca0ec94 Compare June 13, 2022 13:22
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 13, 2022

updated to current state of #12800 cc @alexjo2144

1 similar comment
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 15, 2022

updated to current state of #12800 cc @alexjo2144

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 16, 2022

trino-delta-lake -P cloud-tests failed 😞

Error:  java.lang.OutOfMemoryError: Java heap space
Error:  Terminating due to java.lang.OutOfMemoryError: Java heap space

@alexjo2144
Copy link
Copy Markdown
Member

alexjo2144 commented Jun 16, 2022

I'm really at a loss what to do about the OOM

@alexjo2144 alexjo2144 mentioned this pull request Jun 16, 2022
Merged
@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Jun 17, 2022 •
edited
Loading

Does the issue happen always?

Would it be worth trying with <air.test.jvmsize>4g</air.test.jvmsize> for the cloud-tests profile?

How does the memory consumption look like when executing the tests locally?
I did execute the tests myself.

If changing in the trino-delta-lake projec for the cloud-tests profile, any of the following properties:

            <properties>
                <air.test.parallel>none</air.test.parallel>
                <air.test.thread-count>1</air.test.thread-count>
            </properties>

the memory consumption stays relatively low:
image

The tests will take longer though to complete.

@ebyhr ebyhr force-pushed the findepi/test-with-gcs branch from f6ca780 to 7be4860 Compare July 1, 2022 08:45
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jul 1, 2022

Updated to current state of #12800

@ebyhr ebyhr force-pushed the findepi/test-with-gcs branch from 7be4860 to 887ee07 Compare July 1, 2022 10:31
@ebyhr ebyhr marked this pull request as ready for review July 1, 2022 12:10
@ebyhr ebyhr marked this pull request as draft July 1, 2022 12:10
@ebyhr ebyhr force-pushed the findepi/test-with-gcs branch 2 times, most recently from f5e2638 to c9447c6 Compare July 4, 2022 05:58
@ebyhr ebyhr force-pushed the findepi/test-with-gcs branch from c9447c6 to c52f8b5 Compare August 4, 2022 22:28
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Aug 10, 2022

replaced by #13592

@findepi findepi closed this Aug 10, 2022
@findepi findepi deleted the findepi/test-with-gcs branch August 10, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findinpath findinpath Awaiting requested review from findinpath

Assignees

No one assigned

Labels

cla-signed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@findepi @ebyhr @alexjo2144 @findinpath