Improve some default config values of fault-tolerant execution#12646
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Jun 9, 2022
Merged
Improve some default config values of fault-tolerant execution#12646arhimondr merged 1 commit intotrinodb:masterfrom
arhimondr merged 1 commit intotrinodb:masterfrom
Conversation
linzebing
force-pushed
the
tardigrade-configs
branch
from
d89ead0 to
5137ef0
Compare
losipiuk
reviewed
Jun 2, 2022
| // enforced against user + system memory allocations (default is maxQueryMemory * 2) | ||
| private DataSize maxQueryTotalMemory; | ||
| private DataSize faultTolerantExecutionTaskMemory = DataSize.of(4, GIGABYTE); | ||
| private DataSize faultTolerantExecutionTaskMemory = DataSize.of(5, GIGABYTE); |
Member
Author
There was a problem hiding this comment.
I simply copied what @arhimondr set in https://github.com/starburstdata/stargate/pull/2729
losipiuk
approved these changes
Jun 2, 2022
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
LGTM.
Maybe put sth for the release notes. Maybe sth like:
Improve execution performance by updating default values
for configuration options related to task sizing
when fault-tolerant execution is used (`retry_mode` is set to `TASK`).
arhimondr
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement
Configs
The new values were found better during our testing of batch workloads.
Related issues, pull requests, and links
Documentation
() No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
() No release notes entries required.
(x) Release notes entries required with the following suggested text: