Skip to content

Validate orc_bloom_filter_columns when creating table#12622

Merged
findepi merged 1 commit intotrinodb:masterfrom
polaris6:add_orc_column_check
Jun 7, 2022
Merged

Validate orc_bloom_filter_columns when creating table#12622
findepi merged 1 commit intotrinodb:masterfrom
polaris6:add_orc_column_check

Conversation

@polaris6
Copy link
Copy Markdown
Member

@polaris6 polaris6 commented Jun 1, 2022

Description

Validate orc_bloom_filter_columns when creating table.

Related issues, pull requests, and links

Fixes #12586

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@polaris6
Copy link
Copy Markdown
Member Author

polaris6 commented Jun 1, 2022

There are two failing checks, but they are not caused by this PR and can be ignored.

@polaris6
Copy link
Copy Markdown
Member Author

polaris6 commented Jun 6, 2022

Hi @findepi, could you please help me review this PR when you have time? Thank you very much!

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 6, 2022

the build is not green

@polaris6 polaris6 force-pushed the add_orc_column_check branch from 7e19a94 to 5f80fd9 Compare June 6, 2022 14:04
@polaris6
Copy link
Copy Markdown
Member Author

polaris6 commented Jun 7, 2022

the build is not green

@findepi I pushed an empty commit for re-triggering CI, this failing check is not caused by this PR.

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 7, 2022

CI #12385

@findepi findepi merged commit 801f7fe into trinodb:master Jun 7, 2022
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 7, 2022
@github-actions github-actions bot added this to the 385 milestone Jun 7, 2022
@polaris6 polaris6 deleted the add_orc_column_check branch June 16, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

The table is successfully created when the column in orc_bloom_filter_columns does not exist

3 participants