Skip to content

Fix formatting cumulative memory in Web UI #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 2 commits into from
May 31, 2022
Merged

Fix formatting cumulative memory in Web UI #12596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33172e5
Automatically tag Web UI related PRs with ui label
losipiuk May 31, 2022
5fd2387
Fix formatting cumulative memory in Web UI
losipiuk May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/config/labeler-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ docs:
release-notes:
- docs/src/main/sphinx/release/**
- docs/src/main/sphinx/release.rst

ui:
- core/trino-main/src/main/resources/webapp/**
2 changes: 1 addition & 1 deletion core/trino-main/src/main/resources/webapp/dist/query.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions core/trino-main/src/main/resources/webapp/src/components/QueryDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,11 +1502,11 @@ export class QueryDetail extends React.Component {
Cumulative User Memory
</td>
<td className="info-text">
{formatDataSizeBytes(query.queryStats.cumulativeUserMemory / 1000.0) + " seconds"}
{formatDataSize(query.queryStats.cumulativeUserMemory / 1000.0) + "*seconds"}
</td>
{taskRetriesEnabled &&
<td className="info-failed">
{formatDataSizeBytes(query.queryStats.failedCumulativeUserMemory / 1000.0) + " seconds"}
{formatDataSize(query.queryStats.failedCumulativeUserMemory / 1000.0) + "*seconds"}
Copy link
Copy Markdown
Member

@findepi findepi May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MB*s ? (MBs would be correct, but not clear)

Copy link
Copy Markdown
Member Author

@losipiuk losipiuk May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with MBs but yeah, I think it is not clear.
Elsewhere we use full seconds (not an abbreviation), so I guess this is fine.

</td>
}
</tr>
Expand Down