Skip to content

Unbind hive config from iceberg and delta lake modules#12567

Merged
findepi merged 2 commits intotrinodb:masterfrom
homar:homar/unbind_hive_config_from_delta_lake_connector
Jun 8, 2022
Merged

Unbind hive config from iceberg and delta lake modules#12567
findepi merged 2 commits intotrinodb:masterfrom
homar:homar/unbind_hive_config_from_delta_lake_connector

Conversation

@homar
Copy link
Copy Markdown
Member

@homar homar commented May 26, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 26, 2022
@homar homar force-pushed the homar/unbind_hive_config_from_delta_lake_connector branch from 9dd1443 to b0fc417 Compare May 26, 2022 20:38
@homar homar marked this pull request as ready for review May 26, 2022 22:57
@homar homar requested a review from findepi May 26, 2022 22:57
@homar homar changed the title Homar/unbind hive config from delta lake connector unbind hive config from delta lake connector May 31, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 2, 2022

let's review this once #12595 is merged

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 3, 2022

please rebase

@homar
Copy link
Copy Markdown
Member Author

homar commented Jun 3, 2022

please rebase

yes i know i was waiting for the other one

@homar homar force-pushed the homar/unbind_hive_config_from_delta_lake_connector branch from b0fc417 to ad11a94 Compare June 3, 2022 16:20
@homar homar changed the title unbind hive config from delta lake connector Unbind hive config from delta lake connector Jun 4, 2022

public class TestIcebergPlugin
{
private static final String HIVE_VIEWS_ENABLED = "hive.hive-views.enabled";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over

@homar homar force-pushed the homar/unbind_hive_config_from_delta_lake_connector branch from ad11a94 to eee4897 Compare June 5, 2022 08:09
@homar homar changed the title Unbind hive config from delta lake connector Unbind hive config from iceberg and delta lake modules Jun 6, 2022
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 8, 2022
@findepi findepi merged commit bd3b0ae into trinodb:master Jun 8, 2022
@github-actions github-actions bot added this to the 385 milestone Jun 8, 2022
@colebow
Copy link
Copy Markdown
Member

colebow commented Jun 8, 2022

We're going to need to include docs for this, too. @homar can you get a PR up today, or do you want me to? Release is today, so it'll need to be a quick turnaround.

cc @findepi

@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 8, 2022

@homar what would be docs changes here?

@homar
Copy link
Copy Markdown
Member Author

homar commented Jun 8, 2022

@colebow PR for docs change #12751
Sorry it took me so long. I had busy afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants