Support coercion within union type for ORC format#12520
Merged
phd3 merged 1 commit intotrinodb:masterfrom Jun 13, 2022
Merged
Conversation
Felicity-3786
changed the title
electrum
reviewed
May 25, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
phd3
approved these changes
Jun 6, 2022
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
Looks good, mostly minor comments
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
Felicity-3786
force-pushed
the
union_type
branch
2 times, most recently
from
3d4db00 to
1afcd15
Compare
Member
|
@Felicity-3786 can you please take a look at CI failures |
phd3
approved these changes
Jun 10, 2022
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Pratham Desai <prathamd94@gmail.com>
Felicity-3786
force-pushed
the
union_type
branch
from
045ebf4 to
d02d3dd
Compare
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Pratham Desai prathamd94@gmail.com
Description
This PR adds support for union-type coercion in ORC format. Mainly two changes here:
It's a fix for Trino queries with table/partition mismatch errors.
The reason is that even though unions are treated as structs, union coercion isn't handled.
Hive Plugin
This PR handles the schema evolution for union-type(struct), coercion policy is added for ORC format.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: