Unify the Docker image build scripts#12507
Merged
martint merged 2 commits intotrinodb:masterfrom May 27, 2022
Merged
Conversation
nineinchnick
force-pushed
the
simplify-building-docker-image
branch
from
4d0ae38 to
c76b785
Compare
findepi
reviewed
May 23, 2022
findepi
reviewed
May 23, 2022
nineinchnick
force-pushed
the
simplify-building-docker-image
branch
from
c76b785 to
b7ef3ff
Compare
findepi
reviewed
May 23, 2022
nineinchnick
force-pushed
the
simplify-building-docker-image
branch
2 times, most recently
from
de50f40 to
ffd367f
Compare
findepi
approved these changes
May 24, 2022
hashhar
approved these changes
May 24, 2022
nineinchnick
force-pushed
the
simplify-building-docker-image
branch
from
ffd367f to
8e1d9fc
Compare
hashhar
approved these changes
May 24, 2022
Member
|
CI hit #12535 |
hashhar
reviewed
May 25, 2022
Member
|
cc: @martint FYI - not much changes for the releases.
|
Member
|
Thanks, this is a nice improvement! In particular, it saves having to re-download the tgz artifacts from maven central if something fails when building the docker image. |
Member
|
Before merging, can you make the corresponding change to https://github.com/trinodb/release-scripts/blob/master/trino-docker.sh so we can get them both in at the same time? |
Member
Author
|
@martint here you go: trinodb/release-scripts#4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unify both build scripts into one and make it recognize flags and print a helpful usage message. Use Maven to download artifacts when building an image for a released version.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: