Support query pass-through for BigQuery connector#12502
Merged
Conversation
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
4 times, most recently
from
c60941a to
13654e7
Compare
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
from
13654e7 to
f61a341
Compare
Member
|
This will need docs .. @colebow can you maybe create a PR with the help of @ebyhr for technical input. Or at least figure out whats up. To some degree I think this does NOT yet need docs since its is related to table functions exposure and if we dont have any yet in the connector .. then this is just plumbing without user facing impact. @kasiafi might also be able to clarify |
mosabua
added
the
needs-docs
Member
Member
|
Thanks for confirming @kasiafi ! |
Member
|
fyi @brianzhan |
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
2 times, most recently
from
5ba6aa5 to
47fe830
Compare
Member
Author
|
Removing |
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
from
47fe830 to
862e966
Compare
ebyhr
removed
the
needs-docs
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
from
862e966 to
89744d0
Compare
Member
Author
|
Updated documentation based on MySQL connector. Ready for review now. |
mosabua
approved these changes
Jul 4, 2022
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
2 times, most recently
from
2b8704b to
80d95a0
Compare
Member
Author
hashhar
approved these changes
Jul 22, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
ebyhr
commented
Jul 27, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Show resolved
Hide resolved
wendigo
reviewed
Aug 17, 2022
wendigo
reviewed
Aug 17, 2022
Contributor
wendigo
left a comment
wendigo
left a comment
There was a problem hiding this comment.
Overall design looks good to me.
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ptf/Query.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-query-pass-through
branch
from
80d95a0 to
c35a256
Compare
Member
Author
|
Let me merge this PR if there's no additional comments until tomorrow. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support query pass-through for BigQuery connector
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
(x) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: