Remove deprecated version of getTableStatistics#12489
Merged
findepi merged 3 commits intotrinodb:masterfrom Jun 9, 2022
Merged
Remove deprecated version of getTableStatistics#12489findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
nineinchnick
force-pushed
the
remove-deprecated-get-table-stats
branch
from
c8507dd to
f2da753
Compare
Member
|
CI is red. |
nineinchnick
force-pushed
the
remove-deprecated-get-table-stats
branch
2 times, most recently
from
a1cfe4b to
8657845
Compare
Member
Author
|
@findepi I added a second commit that also removes it from the JDBC-based plugins. Should we also deprecate it first, before removing it? |
nineinchnick
force-pushed
the
remove-deprecated-get-table-stats
branch
from
8657845 to
a566bfe
Compare
Member
Author
|
@findepi this is now ready for review. |
findepi
reviewed
May 31, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/jmx/StatisticsAwareJdbcClient.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 31, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ForwardingJdbcClient.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 31, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 31, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
remove-deprecated-get-table-stats
branch
2 times, most recently
from
8f00ab6 to
0b9549e
Compare
findepi
reviewed
Jun 6, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Jun 6, 2022
nineinchnick
force-pushed
the
remove-deprecated-get-table-stats
branch
from
0b9549e to
9f17e62
Compare
findepi
approved these changes
Jun 9, 2022
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was deprecated in #11877, released as 378, so still relatively recent.
Related issues, pull requests, and links
Documentation
(x ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: