Skip to content

Remove redundant call to 'String.format()'#12437

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
groobyming:remove-redundant-call-String-format
Jun 8, 2022
Merged

Remove redundant call to 'String.format()'#12437
ebyhr merged 1 commit intotrinodb:masterfrom
groobyming:remove-redundant-call-String-format

Conversation

@groobyming
Copy link
Copy Markdown
Contributor

Description

Remove redundant call to 'String.format()'

Class:
io.trino.client.auth.external.CompositeRedirectHandler
Code:

@Override
public void redirectTo(URI uri) throws RedirectException
{
    RedirectException redirectException = new RedirectException(format("Could not redirect to " + uri));
    for (RedirectHandler handler : handlers) {
        try {
            handler.redirectTo(uri);
            return;
        }
        catch (RedirectException e) {
            redirectException.addSuppressed(e);
        }
    }
    throw redirectException;
}

Documentation

(x) No documentation is needed.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: groobyming.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize the commit title (not PR title):

Remove redundant String.format()

https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

Also, have you already submit CLA?
https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: groobyming.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@groobyming groobyming force-pushed the remove-redundant-call-String-format branch from a4fdb7f to 94564f0 Compare May 17, 2022 22:57
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: groobyming.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@groobyming groobyming changed the title remove redundant call to 'String.format()' Remove redundant call to 'String.format()' May 17, 2022
@groobyming
Copy link
Copy Markdown
Contributor Author

groobyming commented May 17, 2022

@ebyhr Thanks for your advise, I have capitalized the submission title. Also I have submitted a CLA yesterday but have not heard back

@groobyming groobyming force-pushed the remove-redundant-call-String-format branch from 94564f0 to 4060c92 Compare May 18, 2022 09:01
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 18, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@findepi
Copy link
Copy Markdown
Member

findepi commented May 18, 2022

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

@groobyming
Copy link
Copy Markdown
Contributor Author

groobyming commented May 18, 2022

@findepi Hi, findepi, I've sent cla.

@groobyming
Copy link
Copy Markdown
Contributor Author

331652884812_ pic

@groobyming groobyming requested a review from findepi June 8, 2022 03:55
@groobyming groobyming force-pushed the remove-redundant-call-String-format branch from 4060c92 to 1a7a493 Compare June 8, 2022 04:13
@cla-bot cla-bot bot added the cla-signed label Jun 8, 2022
@groobyming
Copy link
Copy Markdown
Contributor Author

groobyming commented Jun 8, 2022

@findepi
Hi,findepi
Due to an operation error, I triggered 'Re-request review', please help me to review again, thank you

@ebyhr ebyhr merged commit ef22bc9 into trinodb:master Jun 8, 2022
@github-actions github-actions bot added this to the 385 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants