Skip to content

Support reading wildcard tables in BigQuery#12428

Merged
ebyhr merged 1 commit intomasterfrom
ebi/bigquery-wildcard-table
May 23, 2022
Merged

Support reading wildcard tables in BigQuery#12428
ebyhr merged 1 commit intomasterfrom
ebi/bigquery-wildcard-table

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented May 17, 2022 •
edited
Loading

Description

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
(x) Documentation issue #12432 is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# BigQuery
* Support reading wildcard tables. ({issue}`4124`)

@cla-bot cla-bot bot added the cla-signed label May 17, 2022
@ebyhr ebyhr requested review from hashhar and wendigo May 17, 2022 08:12
hashhar
hashhar approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we now document that specific types of tables will use BigQuery compute for querying instead of Storage API?

@ebyhr ebyhr force-pushed the ebi/bigquery-wildcard-table branch from 98ea1c0 to 389b23a Compare May 17, 2022 08:29
@findepi findepi mentioned this pull request May 17, 2022
Closed
@findepi
Copy link
Member

findepi commented May 17, 2022

Marked this as syntax-needs-review and started a discussion about possible syntaxes in the linked issue: #4124 (comment)

@findepi findepi marked this pull request as draft May 17, 2022 08:44
findepi
findepi reviewed May 17, 2022
View reviewed changes
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryUtil.java Outdated
Copy link
Member

@findepi findepi May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the change, could a user create a table with asterisk in its name?

Copy link
Member Author

@ebyhr ebyhr May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Table name must be alphanumeric and underscores.

plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryConnectorTest.java Outdated
Copy link
Member

@findepi findepi May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the top-level exception being raised? add assertion on it's message

Copy link
Member

@findepi findepi May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests with INSERT, ADD COLUMN, RENAME

Copy link
Member Author

@ebyhr ebyhr May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to throw an exception explicitly and added some cases.

@ebyhr ebyhr force-pushed the ebi/bigquery-wildcard-table branch from 389b23a to a65cf5f Compare May 17, 2022 09:18
@ebyhr ebyhr force-pushed the ebi/bigquery-wildcard-table branch from a65cf5f to 4b8899a Compare May 19, 2022 00:51
@ebyhr
Copy link
Member Author

ebyhr commented May 19, 2022

Just rebased on upstream to resolve conflicts.

@findepi findepi marked this pull request as ready for review May 20, 2022 09:53
@findepi findepi requested a review from hashhar May 20, 2022 09:53
@ebyhr ebyhr merged commit a398d66 into master May 23, 2022
@ebyhr ebyhr deleted the ebi/bigquery-wildcard-table branch May 23, 2022 06:38
@ebyhr ebyhr mentioned this pull request May 23, 2022
Closed
@github-actions github-actions bot added this to the 382 milestone May 23, 2022
This was referenced May 24, 2022
Merged
Closed
@findinpath findinpath mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi left review comments

@hashhar hashhar hashhar approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees

No one assigned

Labels

cla-signed

Milestone

382

Development

Successfully merging this pull request may close these issues.

wildcard tables not supported for BigQuery connector

3 participants

@ebyhr @findepi @hashhar