Skip to content

Improve PostgreSQL INSERT performance #12417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 3 commits into from
May 17, 2022
Merged

Improve PostgreSQL INSERT performance #12417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abb99cb
Improve PostgreSQL INSERT performance
wendigo May 15, 2022
974e7bf
Apply suggestions from code review
electrum May 16, 2022
233be49
Update plugin/trino-postgresql/src/main/java/io/trino/plugin/postgres…
electrum May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugin/trino-postgresql/src/main/java/io/trino/plugin/postgresql/PostgreSqlClientModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@
import io.trino.plugin.jdbc.credential.CredentialProvider;
import org.postgresql.Driver;

import java.util.Properties;

import static com.google.inject.multibindings.OptionalBinder.newOptionalBinder;
import static io.airlift.configuration.ConfigBinder.configBinder;
import static io.trino.plugin.jdbc.JdbcModule.bindSessionPropertiesProvider;
import static org.postgresql.PGProperty.REWRITE_BATCHED_INSERTS;

public class PostgreSqlClientModule
extends AbstractConfigurationAwareModule
Expand All @@ -56,6 +59,8 @@ public void setup(Binder binder)
@ForBaseJdbc
public ConnectionFactory getConnectionFactory(BaseJdbcConfig config, CredentialProvider credentialProvider)
{
return new DriverConnectionFactory(new Driver(), config, credentialProvider);
Properties connectionProperties = new Properties();
connectionProperties.put(REWRITE_BATCHED_INSERTS.getName(), "true");
return new DriverConnectionFactory(new Driver(), config.getConnectionUrl(), connectionProperties, credentialProvider);
}
}