Add checks for rename table and view#12402
Conversation
|
Please add Related issues, pull requests, and links |
There was a problem hiding this comment.
Use GENERIC_USER_ERROR error here.
There was a problem hiding this comment.
Changed to GENERIC_USER_ERROR. Thanks!
There was a problem hiding this comment.
Use GENERIC_USER_ERROR here.
There was a problem hiding this comment.
Changed to GENERIC_USER_ERROR. Thanks!
|
Please squash the commits. |
There was a problem hiding this comment.
Sorry for the confusion.
TABLE_ALREADY_EXISTS is fit in this specific case.
There was a problem hiding this comment.
Unrelated to your PR: Can you please add a new commit for changing the error code from TABLE_ALREADY_EXISTS to GENERIC_USER_ERROR in this specific case ? (pls mind also the corresponding test case)
There was a problem hiding this comment.
Done! also add the UT for this. Please help review again, Thanks!
lukasz-stec
left a comment
lukasz-stec
left a comment
There was a problem hiding this comment.
lgtm % order of checks
Also, please squash commits.
core/trino-main/src/main/java/io/trino/execution/RenameTableTask.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The same comment for order of checks as above in RenameTableTask
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
Thank you for your improvement.
|
@findinpath @lukasz-stec Could you help merge this pr? Thanks! |
@findepi or @sopel39 need to review it first. This may take some time. |
|
thank you @zhaoyim thanks @findinpath @lukasz-stec for your review |
findepi
added
the
no-release-notes
4 participants
Description
Related issues, pull requests, and links
issue: Add checks for target table.view,mv during view/table rename 12337
PR: checks for rename table and view 12402
Documentation
( *) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:
Fixes #12337